[Skyeye-developer] Small Problem of GTK_LCD and WIN32_LCD both enabled

[Yonghao Wang]

Hi Tony,

I have cygwin with gtk-dev installed, some users may have same system config
like me. If we do "make", skyeye will enable both GTK_LCD = 1 and WIN32_LCD
= 1 and compiling with both gtk lib and gdi32 lib:

".... -Lc:/PROGRA~1/COMMON~1/GTK/2.0/lib -lgtk-win32-2.0
-lgdk-win32-2.0.... -lgdi32 ... -lgdi32 -lkernel32 -luser32"
. It ends up buggy simulation of LCD on my system.

Regarding your work on Makefile regarding GTK_LCD and WIN32_LCD below, I
understand you provide NO_GTK_LCD option. It isn't n mentioned on README so
may confuse end users. I can either
1. add information in README to let user know the conflicting problem, or
2. add GTK_LCD = 0 in msys and cygwin section. to avoid NO_GTK_LCD option
(which I did in my local working copy).
even more to write more sophisticate check script. this is small problem
though,  Your suggestion will be welcome, Thanks

Y.Wang

-----------------------------------------------------------------------------------------------------------------------
# Anthony Lee 2006-09-18 : LCD definiens
HAS_LCD = 0
ifndef NO_LCD
        ifndef NO_GTK_LCD
                ifneq ($(shell pkg-config --atleast-version=2.0.0 gtk+-2.0 >
/dev/null 2>&1 || echo "false"),false)
                        GTK_LCD = 1
                        HAS_LCD = 1
                endif
        endif
        ifeq ($(OSTYPE),msys)
                WIN32_LCD = 1
                HAS_LCD = 1
        else
                ifeq ($(OSTYPE),cygwin)
                        WIN32_LCD = 1
                        HAS_LCD = 1
                endif
        endif
        ifeq ($(OSTYPE),beos)
                BEOS_LCD = 1
                HAS_LCD = 1
        endif
        ifeq ($(HAS_LCD),0)
                NO_LCD = 1
        endif
endif # !NO_LCD
-----------------------------------------------------------------------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.gro.clinux.org/pipermail/skyeye-developer/attachments/20070403/f1da669a/attachment.htm